ayushtkn commented on PR #4620: URL: https://github.com/apache/hive/pull/4620#issuecomment-1701662141
I gave a quick shot on **Impala** and it doesn't have a semi-colon either <img width="1030" alt="image" src="https://github.com/apache/hive/assets/25608848/5b4b9bc6-65d7-4829-8805-94aa28f0b1bc";> Atleast for the normal show create table command & so does hive as of today for normal show create table I checked Spark's official documentation https://spark.apache.org/docs/3.0.0-preview/sql-ref-syntax-aux-show-create-table.html It doesn't have a semi-colon either <img width="790" alt="image" src="https://github.com/apache/hive/assets/25608848/1ae49910-11ac-4c90-a727-7fd18e303688";> Tried on **Spark Shell**: <img width="927" alt="spark-show" src="https://github.com/apache/hive/assets/25608848/a77aaddd-5799-4adf-88f6-fe424a2e55d9";> Checked **MySql** doc as well: https://dev.mysql.com/doc/refman/8.0/en/show-create-table.html <img width="1168" alt="image" src="https://github.com/apache/hive/assets/25608848/086a588e-2624-4a2e-95cb-e400128e26f2";> Maybe I am checking the wrong pages or did something wrong while trying these commands. I have limited to NIL experience in these technologies... But in general also CLI output irrespective of other engines should be maintained, these aren't my thoughts. This is actually documented in the Hadoop Compat guidelines, which Hive was a part <img width="1534" alt="image" src="https://github.com/apache/hive/assets/25608848/4ff40740-561c-4903-9232-c0919d9ba531";> And it is not just for the sake of writing, these compat rules are indeed followed even for minor and things which are considered to be good. My intentions aren't to use compat guidelines to stop anyone from doing anything or impose to folks what just I believe. I can quote an example where I was a participant as well for a cli change which is indeed good for users and quite trivial as well and it got reverted, though it looked good, just for the sake of compat https://issues.apache.org/jira/browse/HDFS-13732?focusedCommentId=16685728&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16685728 > When are we allowed to break compatibility? The answer is Never, we aren't allowed to break compatibility, we break it only incase of unavoidable circumstances following a certain pattern, like deprecating and stuff like that, that also can be surpassed in case of security issues and things like that. This is what my limited experience in the ecosystem says. But if people feel it is a good thing & we should go with it, I won't block it, upto you folks!!! -0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
