sankarh commented on code in PR #4639: URL: https://github.com/apache/hive/pull/4639#discussion_r1318451734
########## ql/src/test/org/apache/hadoop/hive/ql/exec/vector/expressions/TestVectorTypeCasts.java: ########## @@ -24,13 +24,15 @@ import java.math.BigDecimal; import java.sql.Timestamp; +import java.text.SimpleDateFormat; import java.util.Random; import java.util.concurrent.TimeUnit; import junit.framework.Assert; import org.apache.hadoop.hive.common.type.DataTypePhysicalVariation; import org.apache.hadoop.hive.common.type.HiveDecimal; +import org.apache.hadoop.hive.ql.util.DateTimeMath; Review Comment: testCastDateToString() is missing in branch-3 but in master. Let's cherry pick that test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
