okumin commented on code in PR #4511:
URL: https://github.com/apache/hive/pull/4511#discussion_r1318509711
##########
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java:
##########
@@ -7015,6 +7022,12 @@ public static String checkBucketing(Configuration conf) {
return isAllowed(conf, ConfVars.HIVE_STRICT_CHECKS_BUCKETING) ? null :
NO_BUCKETING_MSG;
}
+ public static void checkOffsetWithoutOrderBy(Configuration conf) throws
SemanticException {
+ if (!isAllowed(conf, ConfVars.HIVE_STRICT_CHECKS_OFFSET_NO_ORDERBY)) {
+ throw new SemanticException(NO_OFFSET_WITHOUT_ORDERBY_MSG);
Review Comment:
@kasakrisz I found a utility method and used it for standardization. This is
an example.
```
$ beeline -e "select * from test limit 10, 10" --hiveconf
hive.fetch.task.conversion=none --hiveconf tez.grouping.min-size=1 --hiveconf
tez.grouping.max-size=1
...
INFO : Warning: OFFSET without ORDER BY is mostly non-deterministic and
meaningless. Please make sure that you really don't need ORDER BY
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
