deniskuzZ commented on code in PR #4645:
URL: https://github.com/apache/hive/pull/4645#discussion_r1323287143
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/mapreduce/IcebergInputFormat.java:
##########
@@ -201,6 +200,11 @@ public List<InputSplit> getSplits(JobContext context) {
.ofNullable(HiveIcebergStorageHandler.table(conf,
conf.get(InputFormatConfig.TABLE_IDENTIFIER)))
.orElseGet(() -> Catalogs.loadTable(conf));
+ conf.set(InputFormatConfig.TABLE_IDENTIFIER, table.name());
Review Comment:
could we do the conf setup when loading the table:
````
Table table = Optional
.ofNullable(HiveIcebergStorageHandler.table(conf,
conf.get(InputFormatConfig.TABLE_IDENTIFIER)))
.orElseGet(() -> {
Table hadoopTable = Catalogs.loadTable(conf);
conf.set(InputFormatConfig.TABLE_IDENTIFIER, hadoopTable.name());
conf.set(InputFormatConfig.SERIALIZED_TABLE_PREFIX +
hadoopTable.name(), SerializationUtil.serializeToBase64(hadoopTable));
return hadoopTable;
});
````
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
