jfsii commented on PR #4621: URL: https://github.com/apache/hive/pull/4621#issuecomment-1716136151
I think @ayushtkn is correct, if it no longer accepts "1gb", "512mb", etc it should be fixed. I think the original version of the patch was closer to ideal - https://github.com/apache/hive/pull/4137/files Though it seemed to have gotten committed and reverted for a large amount of test failures. I suspect it got changed to getInt due to the suggestion: "you have changed the sizeVar to a number earlier it was 1gb now it is a number, so you need to do a getIntVar or something of that sort." I think your suggestion here of 2147483647b fixes the issue with the prior patch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
