SourabhBadhya commented on code in PR #4672:
URL: https://github.com/apache/hive/pull/4672#discussion_r1335521670


##########
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaHook.java:
##########
@@ -175,6 +175,10 @@ default void rollbackAlterTable(Table table, 
EnvironmentContext context) throws
    * @throws MetaException
    */
   public default void preTruncateTable(Table table, EnvironmentContext 
context) throws MetaException {
+    preTruncateTable(table, context, null);
+  }
+
+  public default void preTruncateTable(Table table, EnvironmentContext 
context, List<String> partNames) throws MetaException {

Review Comment:
   Its kept empty in order to not perform anything for other storage handlers.



##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/IcebergTableUtil.java:
##########
@@ -258,4 +259,28 @@ public static void cherryPick(Table table, long 
snapshotId) {
     LOG.debug("Cherry-Picking {} to {}", snapshotId, table.name());
     table.manageSnapshots().cherrypick(snapshotId).commit();
   }
+
+  public static TransformSpec.TransformType getTransformType(Transform<?, ?> 
transform) {
+    String transformString = transform.toString();
+    if (transformString.contains("bucket")) {

Review Comment:
   Done.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to