SourabhBadhya commented on code in PR #4672:
URL: https://github.com/apache/hive/pull/4672#discussion_r1335831679


##########
ql/src/java/org/apache/hadoop/hive/ql/parse/TransformSpec.java:
##########
@@ -61,4 +75,18 @@ public Optional<Integer> getTransformParam() {
   public void setTransformParam(Optional<Integer> transformParam) {
     this.transformParam = transformParam;
   }
+
+  public static TransformType fromString(String transformString) {

Review Comment:
   I wish this was that simple. `transform.toString()` doesn't guarantee that 
it provides the keyword of the transform only, it provides much more than that.
   A `toString()` called on a bucket transform would return something like this 
- 
   
https://github.com/apache/iceberg/blob/master/api/src/main/java/org/apache/iceberg/transforms/Bucket.java#L138-L140



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to