zhangbutao commented on PR #4747:
URL: https://github.com/apache/hive/pull/4747#issuecomment-1737092027

   > Quick look on the exception It seems to be coming somewhere from here
   > 
   > ```
   >       HiveStorageHandler storageHandler = 
createStorageHandler(table.getTTable());
   >       storageHandler.executeOperation(table, executeSpec);
   > ```
   > 
   > is storageHandler null? Why? Can we just have a null check there & shoot 
an unsupported exception there, rather than these other checks?
   
   Changed. I like you suggestion. It looks much simpler and cleaner. Thx.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org

Reply via email to