scarlin-cloudera commented on code in PR #4442:
URL: https://github.com/apache/hive/pull/4442#discussion_r1340154634
##########
ql/src/java/org/apache/hadoop/hive/ql/ppd/OpProcFactory.java:
##########
@@ -385,6 +385,23 @@ public Object process(Node nd, Stack<Node> stack,
NodeProcessorCtx procCtx,
}
+ public static class LateralViewJoinerPPD extends JoinerPPD implements
SemanticNodeProcessor {
+ @Override
+ public Object process(Node nd, Stack<Node> stack, NodeProcessorCtx procCtx,
+ Object... nodeOutputs) throws SemanticException {
+ Object o = super.process(nd, stack, procCtx, nodeOutputs);
+ Operator<?> operator = (Operator<?>) nd;
+ OpWalkerInfo owi = (OpWalkerInfo) procCtx;
+ if (HiveConf.getBoolVar(owi.getParseContext().getConf(),
+ HiveConf.ConfVars.HIVEPPDREMOVEDUPLICATEFILTERS)) {
+ // remove all the candidate filter operators
+ // when we get to the TS
Review Comment:
I changed the comment for this.
At this point, the filter is both above and below, which is what you saw in
the regression in the last push.
If we don't remove the candidate filter here, there is a "clear()" that is
called before it hits the TS and the original filter does not get removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
