zabetak commented on code in PR #4765:
URL: https://github.com/apache/hive/pull/4765#discussion_r1342402547
##########
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java:
##########
@@ -701,6 +701,9 @@ public enum ConfVars {
"datanucleus.connectionPoolingType", "HikariCP", new
StringSetValidator("DBCP",
"HikariCP", "NONE"),
"Specify connection pool library for datanucleus"),
+ CONNECTION_POOLING_LIFETIME("datanucleus.connectionLifetime",
+ "datanucleus.connectionLifetime", 1800,
+ "The maximum lifetime, in seconds, of a connection in the pool, used
in HikariCP only."),
Review Comment:
If it is a Hikari only configuration then it shouldn't be part of
`MetastoreConf`. Also it is strange to have this under `datanucleus` namespace
if it is not a datanucleus configuration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
