nrg4878 commented on PR #4720: URL: https://github.com/apache/hive/pull/4720#issuecomment-1751288260
@zhangbutao Thank for testing this and providing additional set of eyes. > I have tested this change manually in my local hive cluster. This change is mostly ok for me. I have some considerations and maybe we can improve this feature in the future. > > 1. Support kerberos. Most production clusters will enable kerberos, and we need to think how to support this? Agreed. This is a must-do. I started to look into this a bit and I stumbled into roadblock on how to do this when each connector would have its own keytab file. I wasnt sure how to setup the /etc/krb5.conf file. This is going to need some cycles. > 2. Can we guarantee `Driver ` & `JDBC `compatibility between different Hive version. IMO, `hive-exec.jar` and `hive-jdbc.jar` are the mainly jar which are used by jdbc connection. And if I want to use Hive4 to query another Hive3 or Hive2, can we success? This should work. The above output was from a testing the connector deployed on apache-master (4.x) connecting to a HS2 cluster running hive-3.1+. While this proves this works, you have a good point. We need to ensure that they remain compatible. We haven't changed the thrift IDL for HS2 in a very long time. > BTW, in my local cluster, i need to add `hive-jdbc-4.0.0-beta-2-SNAPSHOT.jar` & `hive-service-4.0.0-beta-2-SNAPSHOT.jar` in Tez&MR AppMaster classpath, otherwise, it will fail in case of launching a Tez&MR task. This is not a problem, It's just a reminder for other folks who want to try this feature. I understand the need for hive-jdbc jar (and I assumed it was already on the Tez CP) but do you know what class it needed from the hive-service.jar? We should definitely document this? Would you mind adding a wiki to the hive docs ( we need to document this feature anyhow) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
