deniskuzZ commented on code in PR #4748:
URL: https://github.com/apache/hive/pull/4748#discussion_r1350152023


##########
ql/src/java/org/apache/hadoop/hive/ql/io/sarg/ConvertAstToSearchArg.java:
##########
@@ -106,6 +105,14 @@ private static enum BoxType {
     parse(expression);
   }
 
+  /**
+   * Returns whether the given expression can be completely converted to a 
search argument.
+   * @return True if the expression can be converted completely, otherwise 
false.
+   */
+  public boolean isCompleteConversion() {

Review Comment:
   could it be package-private?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org

Reply via email to