zratkai commented on code in PR #4690:
URL: https://github.com/apache/hive/pull/4690#discussion_r1352596270
##########
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/txn/compactor/TestCrudCompactorOnTez.java:
##########
@@ -108,8 +108,8 @@ private void
testRebalanceCompactionWithParallelDeleteAsSecond(boolean optimisti
conf.setBoolVar(HiveConf.ConfVars.TXN_WRITE_X_LOCK, optimisticLock);
//set grouping size to have 3 buckets, and re-create driver with the new
config
- conf.set("tez.grouping.min-size", "1000");
- conf.set("tez.grouping.max-size", "80000");
+ conf.set("tez.grouping.min-size", "400");
Review Comment:
This test checks compaction on implicit bucketing. The test originally built
on 3 buckets. The implicit bucket number is calculated with many factors, one
is this tez.grouping.min-size size(others are file size etc.). I would say this
are magic numbers in this case. I could not find a matching number to create 3
buckets again with new ORC, so I decided to use 4 what I managed to achieve
with this grouping.min-size and for this I needed to modify this tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
