SourabhBadhya commented on code in PR #4748:
URL: https://github.com/apache/hive/pull/4748#discussion_r1354920338
##########
ql/src/java/org/apache/hadoop/hive/ql/parse/UpdateDeleteSemanticAnalyzer.java:
##########
@@ -287,6 +299,29 @@ private void reparseAndSuperAnalyze(ASTNode tree, Table
mTable, ASTNode tabNameN
}
}
+ private void checkAndPerformStorageMetadataUpdate(Table table,
HiveStorageHandler storageHandler) {
+ if (!deleting() || storageHandler == null) {
+ return;
+ }
+ Map<String, TableScanOperator> topOps = getParseContext().getTopOps();
+ if (!topOps.containsKey(table.getTableName())) {
+ return;
+ }
+ ExprNodeGenericFuncDesc hiveFilter = getParseContext().getTopOps()
+ .get(table.getTableName()).getConf().getFilterExpr();
+ if (hiveFilter == null ||
!ConvertAstToSearchArg.isCompleteConversion(ctx.getConf(), hiveFilter)) {
Review Comment:
Unfortunately, changing the classname is not compatible since the methods of
this class are used by several components. I have created a Result inner class
and exposed a new method which provides this Result object which can hold all
properties with regards to the conversion process (in this case: partial).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
