InvisibleProgrammer commented on code in PR #4740:
URL: https://github.com/apache/hive/pull/4740#discussion_r1362344051
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/impl/ReadyToCleanAbortHandler.java:
##########
@@ -76,7 +76,13 @@ public class ReadyToCleanAbortHandler implements
QueryHandler<List<CompactionInf
" AND \"res1\".\"TC_TABLE\" = \"res3\".\"CQ_TABLE\" " +
" AND (\"res1\".\"TC_PARTITION\" = \"res3\".\"CQ_PARTITION\" " +
" OR (\"res1\".\"TC_PARTITION\" IS NULL AND
\"res3\".\"CQ_PARTITION\" IS NULL))" +
- " WHERE \"res3\".\"RETRY_RECORD_CHECK\" <= 0 OR
\"res3\".\"RETRY_RECORD_CHECK\" IS NULL";
+ " WHERE (\"res3\".\"RETRY_RECORD_CHECK\" <= 0 OR
\"res3\".\"RETRY_RECORD_CHECK\" IS NULL) " +
+ "AND NOT EXISTS (SELECT 1 " +
+ " FROM \"TXN_COMPONENTS\" AS \"txns\" " +
+ " WHERE \"txns\".\"TC_DATABASE\" =
\"res1\".\"TC_DATABASE\" AND \"txns\".\"TC_TABLE\" = \"res1\".\"TC_TABLE\" " +
+ " AND (\"txns\".\"TC_PARTITION\" =
\"res1\".\"TC_PARTITION\" " +
+ " OR (\"txns\".\"TC_PARTITION\" IS NULL
AND \"res1\".\"TC_PARTITION\" IS NULL))" +
+ " AND \"txns\".\"TC_WRITEID\" >
\"res1\".\"MAX_ABORTED_WRITE_ID\")";
Review Comment:
Fixed the table, now it uses COMPACTION_QUEUE.
About the formatting, I disagree with you. That was the only part of this
sql string that was formatted. Anyway, as you requested, I removed the
formatting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
