tarak271 commented on code in PR #4653: URL: https://github.com/apache/hive/pull/4653#discussion_r1365040688
########## ql/src/java/org/apache/hadoop/hive/ql/udf/generic/AbstractGenericUDFArrayBase.java: ########## @@ -123,4 +124,15 @@ ObjectInspector initListOI(ObjectInspector[] arguments) { return ObjectInspectorFactory.getStandardListObjectInspector(initOI(arguments)); } + void checkValueAndListElementTypes(ObjectInspector arrayElementOI, ObjectInspector valueOI, int elementIndex) + throws UDFArgumentTypeException { + // Check if list element and value are of same type + if (!ObjectInspectorUtils.compareTypes(arrayElementOI, valueOI)) { + throw new UDFArgumentTypeException(elementIndex, + String.format("%s type element is expected at function array_position(array<%s>,%s), but %s is found", Review Comment: My bad, created placefolder for function name as well -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org