dengzhhu653 commented on code in PR #4820: URL: https://github.com/apache/hive/pull/4820#discussion_r1372492570
########## standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/events/AlterPartitionsEvent.java: ########## Review Comment: The partitions in this class come from here: https://github.com/apache/hive/blob/master/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java#L853 Ideally it might contain the same two partitions in the list, but we also alter them twice, so I think we should generate the same number of logs. I think we can rename the class to `AlterPartitionListEvent`, what do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
