zhangbutao commented on code in PR #4835:
URL: https://github.com/apache/hive/pull/4835#discussion_r1375919750
##########
ql/src/java/org/apache/hadoop/hive/ql/parse/AlterTableExecuteSpec.java:
##########
@@ -113,10 +113,13 @@ public static class ExpireSnapshotsSpec {
private long fromTimestampMillis = -1L;
+ private int numRetainLast = -1;
+
public ExpireSnapshotsSpec(long timestampMillis) {
this.timestampMillis = timestampMillis;
}
+
Review Comment:
Unrelated change.
##########
ql/src/java/org/apache/hadoop/hive/ql/parse/AlterTableExecuteSpec.java:
##########
@@ -146,13 +157,19 @@ public boolean isExpireByTimestampRange() {
return timestampMillis != -1 && fromTimestampMillis != -1;
}
+ public boolean isExpireByRetainLast() {
+ return numRetainLast != -1;
Review Comment:
What happened if `numRetainLast` <-1, e.g. -2
We can check this value must be >= 1 in somewhere.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
