Indhumathi27 commented on code in PR #4807:
URL: https://github.com/apache/hive/pull/4807#discussion_r1375982859
##########
ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java:
##########
@@ -4184,14 +4196,16 @@ public Set<Partition> getAllPartitionsOf(Table tbl)
throws HiveException {
Hive.get().getConf(), MetastoreConf.ConfVars.BATCH_RETRIEVE_MAX);
if (batchSize > 0) {
return getAllPartitionsInBatches(tbl, batchSize,
DEFAULT_BATCH_DECAYING_FACTOR, MetastoreConf.getIntVar(
- Hive.get().getConf(),
MetastoreConf.ConfVars.GETPARTITIONS_BATCH_MAX_RETRIES));
+ Hive.get().getConf(),
MetastoreConf.ConfVars.GETPARTITIONS_BATCH_MAX_RETRIES), null,
+ false, null, null);
} else {
return getAllPartitions(tbl);
}
}
public Set<Partition> getAllPartitionsInBatches(Table tbl, int batchSize,
int decayingFactor,
- int maxRetries) throws HiveException {
+ int maxRetries, Map<String, String> partialPartitionSpec, boolean
isAuthRequired,
Review Comment:
could create this as a new method and avoid making changes for method calls
where this variables are passed as null
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
