subhasisgorai commented on code in PR #4841:
URL: https://github.com/apache/hive/pull/4841#discussion_r1380148667
##########
shims/common/src/main/java/org/apache/hadoop/hive/shims/Utils.java:
##########
@@ -172,6 +173,10 @@ public static boolean
checkFileSystemXAttrSupport(FileSystem fs) throws IOExcept
LOG.warn("XAttr won't be preserved since it is not supported for file
system: " + fs.getUri());
return false;
}
+ catch (AccessControlException e) {
+ LOG.warn(e.getMessage());
+ return false;
+ }
Review Comment:
@harshal-16, if `Isilon only supports getXAttrs on /.reserved/raw paths`
then this method **returns false is not correct**. We need to check for
`fs.getXAttrs(new Path(Path.SEPARATOR))` at those supported locations only for
Isolon then to check whether whether Xattrs is supported. At this stage do we
have knowledge about the underlying file system?
We also need to test for extended attributes and relevant replication.
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
