deniskuzZ commented on code in PR #4871:
URL: https://github.com/apache/hive/pull/4871#discussion_r1390904056
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java:
##########
@@ -593,6 +594,9 @@ private Path getColStatsPath(Table table) {
}
private Path getColStatsPath(Table table, long snapshotId) {
+ if (((BaseTable) table).operations() instanceof HadoopTableOperations) {
+ return new Path(table.location() + STATS + snapshotId);
Review Comment:
makes sense if we use stats for Hadoop tables, I wasn't sure about that,
most metadata optimizations are available when we use HiveCatalog.
but anyways, not sure why we needed table name in stats file, maybe we
should use similar to manifestList naming:
````
snap-%d-%s", snapshotId(), UUID.randomUUID().toString())
````
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
