kasakrisz commented on code in PR #4832:
URL: https://github.com/apache/hive/pull/4832#discussion_r1393782775
##########
ql/src/java/org/apache/hadoop/hive/ql/parse/MergeSemanticAnalyzer.java:
##########
@@ -295,72 +268,27 @@ private String chooseJoinType(List<ASTNode> whenClauses) {
* cardinality_violation() UDF throws an error whenever it's called killing
the query
* @return true if another Insert clause was added
*/
- private boolean handleCardinalityViolation(StringBuilder rewrittenQueryStr,
ASTNode target,
- String onClauseAsString, Table targetTable, boolean
onlyHaveWhenNotMatchedClause, ColumnAppender columnAppender)
- throws SemanticException {
+ private boolean handleCardinalityViolation(boolean
onlyHaveWhenNotMatchedClause) {
Review Comment:
Implemented Rewriter instead and added MergeStatement to store the parsed
parts of merge. COWMergeRewiter should implement its own cardinality check logic
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
