pan3793 commented on PR #4888: URL: https://github.com/apache/hive/pull/4888#issuecomment-1822461059
> Copy-pasting code from third party projects is not a good idea. In most cases, I agree, but the size should be counted, I don't think it is worth pulling a dependency because of a few lines of code reference. > There is no reason to do it especially since there is no real issue to address in this case. For master branch, there is no real issue, my real target is branch-2.3, just following the common "upstream first" practice to do change on the master branch and then do backport. As you oppose such change on master branch, is it acceptable if I only do such change for branch-2.3? @zabetak -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
