ayushtkn commented on code in PR #4894:
URL: https://github.com/apache/hive/pull/4894#discussion_r1403121362


##########
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/CalciteSemanticException.java:
##########
@@ -30,12 +30,20 @@ public class CalciteSemanticException extends 
SemanticException {
   private static final long serialVersionUID = 1L;
 
   public enum UnsupportedFeature {
-    Distinct_without_an_aggregation, Duplicates_in_RR, 
Filter_expression_with_non_boolean_return_type,
-    Having_clause_without_any_groupby, Invalid_column_reference, 
Invalid_decimal,
-    Less_than_equal_greater_than, Others, Same_name_in_multiple_expressions,
-    Schema_less_table, Select_alias_in_having_clause, Select_transform, 
Subquery,
-    Table_sample_clauses, UDTF, Union_type, Unique_join,
-    HighPrecisionTimestamp // CALCITE-1690
+    DISTINCT_WITHOUT_AN_AGGREGATION,
+    DUPLICATES_IN_RR,
+    FILTER_EXPRESSION_WITH_NON_BOOLEAN_RETURN_TYPE,
+    HAVING_CLAUSE_WITHOUT_ANY_GROUPBY,
+    INVALID_COLUMN_REFERENCE,
+    INVALID_DECIMAL,
+    SAME_NAME_IN_MULTIPLE_EXPRESSIONS,
+    SCHEMA_LESS_TABLE,
+    SELECT_ALIAS_IN_HAVING_CLAUSE,
+    SELECT_TRANSFORM,
+    SUBQUERY,
+    TABLE_SAMPLE_CLAUSES,
+    UNION_TYPE,
+    UNIQUE_JOIN
   };

Review Comment:
   Won't this be an incompatible change, Anyone catching this exception will 
have problems, right?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to