deniskuzZ commented on code in PR #4880:
URL: https://github.com/apache/hive/pull/4880#discussion_r1405833374
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java:
##########
@@ -1011,25 +1018,31 @@ public URI
getURIForAuth(org.apache.hadoop.hive.metastore.api.Table hmsTable) th
Optional<String> metadataLocation =
SessionStateUtil.getProperty(conf,
BaseMetastoreTableOperations.METADATA_LOCATION_PROP);
if (metadataLocation.isPresent()) {
- authURI.append(encodeString(metadataLocation.get()));
+ authURI.append(encodeString(getLocation(metadataLocation.get(),
getDefaultCreateLocation(), conf)));
Review Comment:
could you please refactor `getLocation(....)` to `getPathForAuth(String
path)`
````
return encodeString(location)
````
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
