aturoczy commented on code in PR #4902:
URL: https://github.com/apache/hive/pull/4902#discussion_r1407590622
##########
jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java:
##########
@@ -285,6 +289,16 @@ public HiveConnection(String uri, Properties info) throws
SQLException {
this(uri, info, HiveJdbcBrowserClientFactory.get());
}
+ public HiveConnection Clone() throws SQLException {
Review Comment:
In which use case the Clone is needed? It is not better just to create
another connection with the same connection string?
##########
jdbc/src/java/org/apache/hive/jdbc/HiveResultSetMetaData.java:
##########
@@ -30,6 +30,8 @@
*
*/
public class HiveResultSetMetaData implements java.sql.ResultSetMetaData {
+ private static final String DOT = ".";
Review Comment:
It is a bit overloaded to me to create a constant for DOT that is . - I'm
fine with the . :-)
cc: @ayushtkn @deniskuzZ Is this a design rule to make this static final?
Even in the simplest cases?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
