aturoczy commented on code in PR #4901:
URL: https://github.com/apache/hive/pull/4901#discussion_r1407598886
##########
llap-client/src/java/org/apache/hadoop/hive/llap/registry/impl/LlapZookeeperRegistryImpl.java:
##########
@@ -168,6 +168,10 @@ public String register() throws IOException {
String uniqueId = UNIQUE_ID.toString();
long znodeCreationTimeout = 120;
+ // PersistentNode created on server will be preserved on VW restarts which
will make
Review Comment:
Just this comment is not proper for upstream
##########
llap-client/src/java/org/apache/hadoop/hive/registry/impl/ZkRegistryBase.java:
##########
@@ -353,6 +356,23 @@ protected final void updateServiceRecord(
}
}
+ protected void ensurePersistentNodePath(ServiceRecord srv) throws
IOException {
+ try {
+ String pNodePath = "/" + PATH_JOINER.join(namespace,
StringUtils.substringBetween(workersPath, "/", "/"),
Review Comment:
Is it possible to create a unit test for this join? This one line is bit
overloaded with functions and results and better to have a validation against it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
