deniskuzZ commented on code in PR #4869:
URL: https://github.com/apache/hive/pull/4869#discussion_r1408429750
##########
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/views/HiveAugmentSnapshotMaterializationRule.java:
##########
@@ -139,14 +148,11 @@ public void onMatch(RelOptRuleCall call) {
final RelBuilder relBuilder = call.builder();
relBuilder.push(tableScan);
- List<RexNode> conds = new ArrayList<>();
- final RexNode literalHighWatermark = rexBuilder.makeLiteral(
- mvMetaTableSnapshot.getSnapshotId(), snapshotIdType(relBuilder),
false);
- conds.add(
- rexBuilder.makeCall(
- SqlStdOperatorTable.LESS_THAN_OR_EQUAL,
- ImmutableList.of(snapshotIdInputRef, literalHighWatermark)));
- relBuilder.filter(conds);
+ final RexNode literalSnapshotId = rexBuilder.makeLiteral(
Review Comment:
since you'll have to re-trigger build again, should we rename to
`snapshotIdLiteral`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
