zhangbutao commented on PR #4905: URL: https://github.com/apache/hive/pull/4905#issuecomment-1833230386
> > In this case, dt='20231129' should be dropped successfully? > > But you throw NoSuchObjectException because dt='20231130' doesn't esist, so dt='20231129' also was not dropped? > > We followed the existing behavior in master, which also wanted to throw exception directly if there are missing partitions, even though the missing partitions logic is incorrect. Acutually, your change is not aim for DDL SQL task (`alter table tbl drop partition (dt='20231129'), partition (dt='20231130')`;). Drop partition DDL task will check the missing partitons in HS2 side instead of HMS side: https://github.com/apache/hive/blob/eab6809fbbb6274efea07a6649dab19269f48850/ql/src/java/org/apache/hadoop/hive/ql/ddl/table/partition/drop/AbstractDropPartitionAnalyzer.java#L150-L156 But as you unit test case shows, if users want to call HMS api to drop partitions, then this change is reasonable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
