abstractdog commented on code in PR #4901:
URL: https://github.com/apache/hive/pull/4901#discussion_r1411901827
##########
llap-client/src/java/org/apache/hadoop/hive/registry/impl/ZkRegistryBase.java:
##########
@@ -353,6 +356,23 @@ protected final void updateServiceRecord(
}
}
+ protected void ensurePersistentNodePath(ServiceRecord srv) throws
IOException {
+ try {
+ String pNodePath = "/" + PATH_JOINER.join(namespace,
StringUtils.substringBetween(workersPath, "/", "/"),
Review Comment:
I agree, this code area needs more clarity than hacking something with
"workersPath" and joining it to namespace with slashes
an unit test is much better then a code comment in this case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
