deniskuzZ commented on code in PR #4805:
URL: https://github.com/apache/hive/pull/4805#discussion_r1411924127
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java:
##########
@@ -5835,12 +5836,23 @@ public void performTimeOuts() {
Object savePoint = context.getTransactionStatus().createSavepoint();
int numTxnsAborted = 0;
- for (List<Long> batchToAbort : timedOutTxns) {
+ for (Map<Long, TxnType> batchToAbort : timedOutTxns) {
context.getTransactionStatus().releaseSavepoint(savePoint);
savePoint = context.getTransactionStatus().createSavepoint();
- if (abortTxns(jdbcResource.getConnection(), batchToAbort, true,
false, false, TxnErrorMsg.ABORT_TIMEOUT) == batchToAbort.size()) {
+ if (abortTxns(jdbcResource.getConnection(), new
ArrayList<>(batchToAbort.keySet()), true, false, false,
TxnErrorMsg.ABORT_TIMEOUT) == batchToAbort.size()) {
Review Comment:
could we change the type to `Collection` in abortTxns?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
