deniskuzZ commented on code in PR #4908:
URL: https://github.com/apache/hive/pull/4908#discussion_r1413549018
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java:
##########
@@ -234,6 +240,77 @@ public class HiveIcebergStorageHandler implements
HiveStoragePredicateHandler, H
}
};
+ private static final transient BiFunction<Integer, Integer,
Function<List<ExprNodeDesc>, ExprNodeDesc>>
Review Comment:
this class looks overloaded already, could we move these functions into some
helper class?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
