deniskuzZ commented on code in PR #4910:
URL: https://github.com/apache/hive/pull/4910#discussion_r1413582421
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/mapreduce/IcebergInputFormat.java:
##########
@@ -241,6 +252,14 @@ public List<InputSplit> getSplits(JobContext context) {
return splits;
}
+ private static void validateFilesWithinTableDirectory(CombinedScanTask
split, Path tableLocation) {
+ for (FileScanTask fileScanTask : split.files()) {
+ if (!FileUtils.isPathWithinSubtree(new
Path(fileScanTask.file().path().toString()), tableLocation)) {
+ throw new IllegalArgumentException("The table contains paths which are
outside the table location");
Review Comment:
I don't think that is a valid exception type to throw, should be some ACL or
Authorization/Security exception
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
