zhangbutao commented on code in PR #4917: URL: https://github.com/apache/hive/pull/4917#discussion_r1417208789
########## README.md: ########## @@ -24,7 +24,7 @@ subqueries, common table expressions, and more. Hive's SQL can also be extended with user code via user defined functions (UDFs), user defined aggregates (UDAFs), and user defined table functions (UDTFs). -Hive users have a choice of 3 runtimes when executing SQL queries. +Hive users have a choice of 2 runtimes when executing SQL queries. Review Comment: > Removing the sentence completely would be even better so that we don't have to update the number every time something changes. Agreed! Removed this sentence. Thanks for suggestion! > MapReduce is deprecate so I am not sure it it is really an option maybe worth mentioning this as well. IMHO, at present, it seems that we never had a concrete plan for deprecating MapReduce, so I think it's better not to mention MR deprecation here. I am afraid of this will lead to some confusion for users. > With a little effort the commit summary/JIRA title could become more specific and someone could understand what changed (or is going to change) without looking at the diff. Will change te tilte. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
