deniskuzZ commented on code in PR #4566:
URL: https://github.com/apache/hive/pull/4566#discussion_r1418946961
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java:
##########
@@ -457,7 +306,8 @@ public void setConf(Configuration conf){
throw new RuntimeException(e);
}
- sqlRetryHandler = new SqlRetryHandler(conf,
jdbcResource.getDatabaseProduct());
+ sqlRetryHandler = new SqlRetryHandler(conf,
jdbcResource.getDatabaseProduct());
+ txnLockHandler = TransactionalRetryProxy.getProxy(new
TxnLockHandlerImpl(jdbcResource), sqlRetryHandler, jdbcResource);
Review Comment:
minor, should we change the order of params?
````
TransactionalRetryProxy.getProxy(sqlRetryHandler, jdbcResource, new
TxnLockHandlerImpl(jdbcResource))
````
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
