BsoBird commented on code in PR #4935:
URL: https://github.com/apache/hive/pull/4935#discussion_r1421772693
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/SplitGrouper.java:
##########
@@ -71,7 +71,7 @@ public class SplitGrouper {
// TODO This needs to be looked at. Map of Map to Map... Made concurrent for
now since split generation
// can happen in parallel.
- private static final Map<Map<Path, PartitionDesc>, Map<Path, PartitionDesc>>
cache =
+ private final Map<Map<Path, PartitionDesc>, Map<Path, PartitionDesc>> cache =
Review Comment:
Since the nature of the problem is that HashTable causes deadlocks in
concurrent scenarios, I'm not sure what kind of test case would be appropriate
to add ....
We can only conclude that whenever a cache object is accessed concurrently,
it will trigger a deadlock almost immediately.
For details on deadlocks, you can check jira, which has deadlock-related
logging information.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
