deniskuzZ commented on code in PR #4761:
URL: https://github.com/apache/hive/pull/4761#discussion_r1425476080
##########
iceberg/iceberg-catalog/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java:
##########
@@ -388,8 +390,11 @@ private void setHmsTableParameters(String
newMetadataLocation, Table tbl, TableM
// If needed set the 'storage_handler' property to enable query from Hive
if (hiveEngineEnabled) {
- parameters.put(hive_metastoreConstants.META_TABLE_STORAGE,
- "org.apache.iceberg.mr.hive.HiveIcebergStorageHandler");
+ String storageHandler =
parameters.get(hive_metastoreConstants.META_TABLE_STORAGE);
+ // Check if META_TABLE_STORAGE is not present or does not contain
ICEBERG_STORAGE_HANDLER
Review Comment:
````
if (storageHandler == null ||
HiveIcebergStorageHandler.class.isAssignableFrom(
Class.forName(storageHandler)) {
}
````
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
