tarak271 commented on code in PR #4933:
URL: https://github.com/apache/hive/pull/4933#discussion_r1426999484


##########
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/parse/TestTimedOutTxnNotificationLogging.java:
##########
@@ -194,6 +191,9 @@ private void runHouseKeeperService() {
   }
 
   private void runTxnHouseKeeperService() {
+    ObjectStore objectStore = new ObjectStore();

Review Comment:
   Moved them to setup



##########
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/parse/TestTimedOutTxnNotificationLogging.java:
##########
@@ -93,7 +91,6 @@ private void setConf() {
     MetastoreConf.setBoolVar(hiveConf, MetastoreConf.ConfVars.HIVE_IN_TEST, 
true);
     MetastoreConf.setVar(hiveConf, MetastoreConf.ConfVars.WAREHOUSE, "/tmp");
     MetastoreConf.setTimeVar(hiveConf, MetastoreConf.ConfVars.TXN_TIMEOUT, 
1000, TimeUnit.MILLISECONDS);

Review Comment:
   changed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to