InvisibleProgrammer commented on PR #4949: URL: https://github.com/apache/hive/pull/4949#issuecomment-1857524824
Hi, I understand that we don't expect other value for NNI_ID than 1. But I have some second thoughts about this change: Firstly, the original logic provided a default value. Now, If I understand it correctly, we change it to enforcing 1. But we only enforce it in case the customer uses MariaDb. I see two painful points in that: Firstly, it can surprise us in a future, if we want to change how notification is working. Secondly, we are creating different Metastore schema for Mariadb and other databases. I think we should target consistency when we support multiple database providers. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
