SourabhBadhya commented on code in PR #4960:
URL: https://github.com/apache/hive/pull/4960#discussion_r1431379348
##########
ql/src/java/org/apache/hadoop/hive/ql/stats/BasicStatsTask.java:
##########
@@ -309,9 +309,6 @@ private int aggregateStats(Hive db, Table tbl) {
TransactionalStatsProcessor transactionalStatsProcessor = new
TransactionalStatsProcessor(db, p);
transactionalStatsProcessor.process(statsAggregator);
- if (conf.getBoolVar(ConfVars.TEZ_EXEC_SUMMARY)) {
Review Comment:
Isnt something similar happening on the partition level as well?
https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/stats/BasicStatsTask.java#L378-L381
LogHelper seems to have an additional responsibility of printing in
System.Err / System.out stream. I dont think that can be achieved if we remove
this if block. Probably we should adjust this to an if-else statement.
`if (conf.getBoolVar(ConfVars.TEZ_EXEC_SUMMARY)) {
console.printInfo("Table " + tableFullName + " stats: [" +
toString(p.getPartParameters()) + ']');
} else {
LOG.info("Table " + tableFullName + " stats: [" +
toString(p.getPartParameters()) + ']');
}
`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
