ngsg commented on code in PR #4958:
URL: https://github.com/apache/hive/pull/4958#discussion_r1433884264
##########
ql/src/test/results/clientpositive/llap/mapjoin_filter_on_outerjoin_tez.q.out:
##########
@@ -790,26 +790,23 @@ STAGE PLANS:
sort order: +
Map-reduce partition columns: _col0 (type: int)
Statistics: Num rows: 2 Data size: 24 Basic stats:
COMPLETE Column stats: COMPLETE
- value expressions: _col1 (type: int), _col2 (type:
boolean), (UDFToShort((not _col2)) * 1S) (type: smallint)
+ value expressions: _col1 (type: int), _col2 (type:
boolean)
Execution mode: llap
LLAP IO: all inputs
Reducer 2
Execution mode: llap
Reduce Operator Tree:
- Map Join Operator
+ Merge Join Operator
Review Comment:
MapJoin (+ FOJ + filter) produces wrong result when multiple rows in big
tables share the same key but do not satisfy filter.
In this test case, every row has a unique key. So MapJoin produced correct
result here.
This test covers all kinds of outer join and FiltertagAppenderProc still
affects to other queries.
e.g.
https://github.com/apache/hive/blob/7ff15c9830f1a6988fda9363dc710d75766db889/ql/src/test/results/clientpositive/llap/mapjoin_filter_on_outerjoin_tez.q.out#L336
https://github.com/apache/hive/blob/7ff15c9830f1a6988fda9363dc710d75766db889/ql/src/test/results/clientpositive/llap/mapjoin_filter_on_outerjoin_tez.q.out#L303-L307
UDFToShort(...) is appended by FiltertagAppenderProc and corresponds to
filter expression on table 1.
So I think the current test name is still valid.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
