dengzhhu653 commented on code in PR #3599:
URL: https://github.com/apache/hive/pull/3599#discussion_r1439246896
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java:
##########
@@ -3214,15 +3290,51 @@ private List<Path>
dropPartitionsAndGetLocations(RawStore ms, String catName, St
}
@Override
+ @Deprecated
public void drop_table(final String dbname, final String name, final boolean
deleteData)
throws NoSuchObjectException, MetaException {
- drop_table_with_environment_context(dbname, name, deleteData, null);
+ startFunction("drop_table", ": " + dbname + ":" + name);
+ boolean success = false;
+ Exception ex = null;
+ try {
+ String[] parsedDbName = parseDbName(dbname, conf);
Review Comment:
can we just call `drop_table_core` in these old deprecated methods or just
leave as it is?
Similar to append/drop/get partitions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
