abstractdog commented on code in PR #4954:
URL: https://github.com/apache/hive/pull/4954#discussion_r1444241141
##########
ql/src/java/org/apache/hadoop/hive/ql/parse/StorageFormat.java:
##########
@@ -157,17 +165,41 @@ public boolean fillStorageFormat(ASTNode child) throws
SemanticException {
return true;
}
- private String processStorageHandler(String name) throws SemanticException {
- for (StorageHandlerTypes type : StorageHandlerTypes.values()) {
- if (type.name().equalsIgnoreCase(name)) {
- name = type.className();
- inputFormat = type.inputFormat();
- outputFormat = type.outputFormat();
- break;
+ private String processStorageHandler(ASTNode node) throws SemanticException {
+ if (node.getType() == HiveParser.StringLiteral) {
+ // e.g. STORED BY 'org.apache.iceberg.mr.hive.HiveIcebergStorageHandler'
+ try {
+ return
ensureClassExists(BaseSemanticAnalyzer.unescapeSQLString(node.getText()));
+ } catch (SemanticException e) {
+ throw createUnsupportedStorageHandlerTypeError(node, e);
+ }
+ }
+ if (node.getType() == HiveParser.Identifier) {
+ // e.g. STORED BY ICEBERG
+ for (StorageHandlerTypes type : StorageHandlerTypes.NON_DEFAULT_TYPES) {
+ if (type.name().equalsIgnoreCase(node.getText())) {
+ inputFormat = type.inputFormat();
+ outputFormat = type.outputFormat();
+ assert type.className != null;
Review Comment:
assert is not supposed for production AFAIK, please use explicit null
checking here, e.g.
[Objects.requireNonNull](https://docs.oracle.com/javase/8/docs/api/java/util/Objects.html#requireNonNull-T-java.lang.String-)
this assertion can be done before assigning inpoutFormat/outputFormat
className(), I guess you might want to use method / direct access
consistently
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
