aturoczy commented on code in PR #5003:
URL: https://github.com/apache/hive/pull/5003#discussion_r1454187734
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/DirectSqlUpdatePart.java:
##########
@@ -186,15 +139,12 @@ private void populateInsertUpdateMap(Map<PartitionInfo,
ColumnStatistics> statsP
partIdList, "\"PART_ID\"", true, false);
for (String query : queries) {
- try {
- statement = dbConn.createStatement();
- LOG.debug("Going to execute query " + query);
- rs = statement.executeQuery(query);
+ LOG.debug("Going to execute query " + query);
Review Comment:
Execute query:
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/DirectSqlUpdatePart.java:
##########
@@ -321,15 +261,12 @@ private Map<Long, String> getParamValues(Connection
dbConn, List<Long> partIdLis
Map<Long, String> partIdToParaMap = new HashMap<>();
for (String query : queries) {
- try {
- statement = dbConn.createStatement();
- LOG.debug("Going to execute query " + query);
- rs = statement.executeQuery(query);
+ LOG.debug("Going to execute query " + query);
Review Comment:
same as above
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/DirectSqlUpdatePart.java:
##########
@@ -496,17 +427,14 @@ private Map<PartitionInfo, ColumnStatistics>
getPartitionInfo(Connection dbConn,
for (String query : queries) {
// Select for update makes sure that the partitions are not modified
while the stats are getting updated.
query = sqlGenerator.addForUpdateClause(query);
- try {
- statement = dbConn.createStatement();
- LOG.debug("Going to execute query <" + query + ">");
- rs = statement.executeQuery(query);
+ LOG.debug("Going to execute query <" + query + ">");
Review Comment:
Different debug style with < >
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
