deniskuzZ commented on code in PR #4959:
URL: https://github.com/apache/hive/pull/4959#discussion_r1462838947
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/DatabaseProduct.java:
##########
@@ -749,6 +753,22 @@ public Object getBoolean(boolean val) {
return val;
}
+ public Object convertDateValue(Object dateValue) {
+ assert dateValue instanceof String;
+ Date date = MetaStoreUtils.convertStringToDate((String)dateValue);
+ Object result = MetaStoreUtils.convertDateToString(date);
+ return result;
+ }
+
+ public Object convertTimestampValue(Object timestampValue) {
+ assert timestampValue instanceof String;
+ MetaStoreUtils.convertStringToTimestamp((String) timestampValue);
Review Comment:
what is this? are we mutating the input object?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
