InvisibleProgrammer commented on code in PR #4740:
URL: https://github.com/apache/hive/pull/4740#discussion_r1463281761
##########
ql/src/test/org/apache/hadoop/hive/ql/txn/compactor/handler/TestAbortedTxnCleaner.java:
##########
@@ -282,9 +284,19 @@ public void testCleaningOfAbortedDirectoriesBelowBase()
throws Exception {
cleaner.setCleanupHandlers(Arrays.asList(mockedTaskHandler));
cleaner.run();
- Mockito.verify(mockedFSRemover,
Mockito.times(1)).clean(any(CleanupRequest.class));
+ Mockito.verifyNoInteractions(mockedFSRemover);
Review Comment:
The test creates 4 deltas on the same table and the same partition: 1
committed, 2 aborted and lastly 1 committed.
When the cleaner runs there, it cannot do the clean up because there is a
newer record in the compaction queue with higher write id for the given table
and partition (as the aborted ones are in the middle of the set up).
So that they won't be cleaned, they delete nothing, as the ticket requests
it.
At the end of the test, we run the whole compaction flow again and finish
all the transactions. So that, the directories will be cleaned up.
In my opinion, that is the exact behaviour that was requested in the ticket.
What do you think about that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
