InvisibleProgrammer commented on PR #5039: URL: https://github.com/apache/hive/pull/5039#issuecomment-1911754257
I have concerns about making hive-exec to depend on standalone-metastore, for two reasons: Firstly, we already too complex module dependencies in the project. It just makes it more complex. Secondly, standalone-metastore should be really standalone or as close to standalone as it is possible. I don't know if we have ongoing plans to move standalone metastore out of Hive repository but I can see it as a long-term goal. What about putting the method into some similar purpose util class in the hive-exec module? It is already referenced in hive-it-unit. In that special case, I would be fine with copy-pasting the method to hive-exec only so that standalone-metastore can kept independently from hive-exec. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
