kasakrisz commented on code in PR #5053:
URL: https://github.com/apache/hive/pull/5053#discussion_r1473983118


##########
ql/src/java/org/apache/hadoop/hive/ql/ddl/view/materialized/alter/rebuild/AlterMaterializedViewRebuildAnalyzer.java:
##########
@@ -480,8 +460,6 @@ protected ASTNode fixUpAfterCbo(ASTNode originalAst, 
ASTNode newAst, CalcitePlan
         fixUpASTAggregateInsertDeleteIncrementalRebuild(fixedAST, 
getMaterializedViewASTBuilder());
         return fixedAST;
       case JOIN_INSERT_DELETE_REBUILD:
-        fixUpASTJoinInsertDeleteIncrementalRebuild(fixedAST, 
getMaterializedViewASTBuilder());
-        return fixedAST;

Review Comment:
   At this point CBO plan is already transformed to AST hence we can not fall 
back. However `JOIN_INSERT_DELETE_REBUILD` is never set in the code any more.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to