simhadri-g commented on code in PR #5014:
URL: https://github.com/apache/hive/pull/5014#discussion_r1475256780
##########
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFFromUtcTimestamp.java:
##########
@@ -113,6 +112,14 @@ public Object evaluate(DeferredObject[] arguments) throws
HiveException {
return result;
}
+ protected TimeZone getToTimeZone(TimeZone timezone) {
+ return timezone;
+ }
+
+ protected TimeZone getFromTimeZone(TimeZone timezone) {
Review Comment:
do we need to pass timezone in the arguments? We are returning UTC.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
