AnmolSun commented on code in PR #5046:
URL: https://github.com/apache/hive/pull/5046#discussion_r1475724153


##########
hcatalog/webhcat/svr/pom.xml:
##########
@@ -104,6 +104,16 @@
     <dependency>
       <groupId>org.apache.zookeeper</groupId>
       <artifactId>zookeeper</artifactId>
+      <exclusions>
+        <exclusion>
+          <groupId>ch.qos.logback</groupId>

Review Comment:
   This is required because Zookeeper introduced dependency on logback at 
[ZOOKEEPER-4427](https://issues.apache.org/jira/browse/ZOOKEEPER-4427) which is 
not required as [Hive uses 
log4j2](https://issues.apache.org/jira/browse/HIVE-25795). Excluded logback 
dependencies similar to that done in 
[Hadoop](https://github.com/apache/hadoop/pull/6296/files). The logging for 
Zookeeper client will not get impacted as log4j2 should also be compatible (Ref 
[here](https://github.com/apache/zookeeper/pull/1793#pullrequestreview-857545860))



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to